Skip to content

Remove the use of Data and EventHandler in our unit tests#26685

Merged
Johann-S merged 2 commits intov4-without-jqueryfrom
v4-dev-jo-data
Jun 9, 2018
Merged

Remove the use of Data and EventHandler in our unit tests#26685
Johann-S merged 2 commits intov4-without-jqueryfrom
v4-dev-jo-data

Conversation

@Johann-S
Copy link
Copy Markdown
Member

@Johann-S Johann-S commented Jun 7, 2018

Removing the use of our Data and EventHandler in unit tests, because they are internal objects not exposed

Next PR will help us to grow our coverage in this branch 🙌

/CC @XhmikosR , @bardiharborow

@Johann-S Johann-S mentioned this pull request Jun 8, 2018
45 tasks
@Johann-S Johann-S changed the title fix(data): do not use data object in our unit tests Remove the use of Data and EventHandler in our unit tests Jun 8, 2018
@Johann-S Johann-S requested a review from XhmikosR June 8, 2018 19:20
@Johann-S
Copy link
Copy Markdown
Member Author

Johann-S commented Jun 9, 2018

I'll merge that PR @XhmikosR, if you have concerns about that change please let me know and I'll change that

@Johann-S Johann-S merged commit 5a30af8 into v4-without-jquery Jun 9, 2018
@Johann-S Johann-S deleted the v4-dev-jo-data branch June 9, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant