Skip to content

Prevent pointer-events on disabled anchor dropdown-item#26700

Merged
XhmikosR merged 2 commits intotwbs:v4-devfrom
howardcox:disabled-anchors-26695
Sep 26, 2018
Merged

Prevent pointer-events on disabled anchor dropdown-item#26700
XhmikosR merged 2 commits intotwbs:v4-devfrom
howardcox:disabled-anchors-26695

Conversation

@howardcox
Copy link
Copy Markdown
Contributor

Fixes #26695

@howardcox howardcox force-pushed the disabled-anchors-26695 branch 3 times, most recently from 8381a15 to 1ab4187 Compare June 12, 2018 07:51
@andresgalante
Copy link
Copy Markdown
Collaborator

Why are you qualifying the selector?

You could add this under:

&.disabled,
  &:disabled {

on line 137. Or am I missing something?

Copy link
Copy Markdown
Collaborator

@andresgalante andresgalante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @howardcox I've just patched your PR to have the desired result without the qualifying the selector.

Thanks a lot!

@howardcox
Copy link
Copy Markdown
Contributor Author

Thanks, sorry I was out-of-office until today otherwise I'd have patched it.

I originally qualified the selector with a because that's what _buttons.scss does for regular non-menu buttons.

@andresgalante
Copy link
Copy Markdown
Collaborator

Right, but even if dropdown-item is a btn I don't how it hurts to have the pointer events none there.

cc/ @patrickhlauke am I missing something?

@howardcox
Copy link
Copy Markdown
Contributor Author

Can this get merged at some point? It's missed 4.1.2 and 4.1.3

@XhmikosR
Copy link
Copy Markdown
Member

Ping @patrickhlauke

@jquense
Copy link
Copy Markdown
Contributor

jquense commented Aug 28, 2018

I'd expect list-group-item to also have this for consistency yeah?

@howardcox howardcox force-pushed the disabled-anchors-26695 branch from 8c1172f to e8ac9ca Compare September 5, 2018 10:03
@howardcox
Copy link
Copy Markdown
Contributor Author

Ok e8ac9ca adds this to _list-group.scss too

@XhmikosR
Copy link
Copy Markdown
Member

Ping @patrickhlauke

@XhmikosR XhmikosR force-pushed the disabled-anchors-26695 branch from 45a002f to a4aa121 Compare September 26, 2018 03:58
@XhmikosR XhmikosR force-pushed the disabled-anchors-26695 branch from a4aa121 to 1f26357 Compare September 26, 2018 04:15
@XhmikosR XhmikosR merged commit d7f79b0 into twbs:v4-dev Sep 26, 2018
@mdo mdo mentioned this pull request Sep 26, 2018
@howardcox howardcox deleted the disabled-anchors-26695 branch December 31, 2018 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants