Fixes modal positioning on android (#26760)#26811
Fixes modal positioning on android (#26760)#26811jvitela wants to merge 0 commit intotwbs:v4-devfrom
Conversation
|
@MartijnCuppens, @mdo Can somebody review this changes? They've been sitting here for a while :-( |
|
I don't have an Android on me at this time to test unfortunately. Anyone else? |
|
@mdo: You can use Browser Stack. @MartijnCuppens: can you review please? |
|
@jvitela, can you also add this fix for |
|
This is better, but now I see the backdrop isn't stretching at the bottom when address bar is hidden. Can you check if you can fix this @jvitela? |
|
Using viewport units for sizing |
|
@MartijnCuppens If you confirmed latest changes fix your issues, this looks good to me. I don't have an Android phone right now to test myself. |
|
Nope, Edit: |
704584a to
eeea8b5
Compare
|
Something went wrong here, we're looking into it |
When address bar is hidden, sometimes the visual position of the controls is out of sync with its logical position.