Ensure calling dispose on a popover will not set the title of the popover next time it is created#26848
Merged
Johann-S merged 5 commits intotwbs:v4-devfrom Aug 2, 2018
jarstelfox:patch-1
Merged
Ensure calling dispose on a popover will not set the title of the popover next time it is created#26848Johann-S merged 5 commits intotwbs:v4-devfrom jarstelfox:patch-1
Johann-S merged 5 commits intotwbs:v4-devfrom
jarstelfox:patch-1
Conversation
jarstelfox
changed the title
Johann-S
requested changes
Jul 11, 2018
Member
There was a problem hiding this comment.
Can you remove destroy because it doesn't exist anymore
see: #26847 in v4, destroy was replaced by dispose
Contributor
Author
|
I've addressed your requested changes |
Contributor
|
@Johann-S Review please! |
Johann-S
approved these changes
Aug 2, 2018
Closed
|
good
… 在 2018年8月2日，下午5:48，Johann-S ***@***.***> 写道：
@Johann-S approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#26848 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXGWn_vitCXDD-tRTGFHPgSZvehTODknks5uMssBgaJpZM4VJ93f>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26847
After doing some digging it looks like popover was previously checking for destroy, but this has been renamed to dispose in v4