Add transition to property-blacklist#26922
Merged
XhmikosR merged 2 commits intotwbs:v4-devfrom Oct 21, 2018
Merged
Conversation
XhmikosR
approved these changes
Aug 13, 2018
Member
|
@MartijnCuppens: there are more instances of transition in docs. |
Member
Author
|
Changed it. The stylelint check also happens on the custom css files. There are several ways we can handle this:
@media screen and (prefers-reduced-motion: reduce) {
.selector {
transition: none;
}
}
Which way do you want to go with this? |
Member
|
Hmmm... not sure to be honest. @andresgalante @mdo thoughts? |
XhmikosR
reviewed
Oct 20, 2018
Member
|
@MartijnCuppens: Perhaps you could to the same for other properties? About the examples, we have a .stylelintrc in the examples folder. You can disable the check there instead of each CSS file. https://github.com/twbs/bootstrap/blob/v4-dev/site/docs/4.1/examples/.stylelintrc |
mdo
approved these changes
Oct 21, 2018
c299670 to
493ec42
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In each PR, we need to check manually if the
@transitionmixin is used instead of thetransitionproperty. By adding this stylelint rule, thecss-lintcommand will take care of this.