Conversation
XhmikosR
force-pushed
the
v4-dev-xmr-dev
branch
3 times, most recently
from
3c1fc41 to
4f759d4
Compare
Member
Author
|
OK, I pushed a couple more patches. |
XhmikosR
force-pushed
the
v4-dev-xmr-dev
branch
from
4f759d4 to
e8586dc
Compare
Member
Author
|
Ping @mdo |
Member
Author
|
@Johann-S: can you please review? There's no point in waiting indefinitely for a review. |
Johann-S
approved these changes
Aug 12, 2018
It's slower, but since it runs only on Travis, we better be safe.
XhmikosR
force-pushed
the
v4-dev-xmr-dev
branch
from
9ff6864 to
561fb6e
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Johann-S: do not merge please
@mdo: please confirm.
Refs #26994