Move hand cursor for buttons to reboot#27021
Conversation
patrickhlauke
left a comment
There was a problem hiding this comment.
This looks tidy to me (though I bet people still won't be happy, or start asking why we're not doing it for generic .btn applied to arbitrary elements as well...)
|
similar PR and discussion in #25598 |
andresgalante
left a comment
There was a problem hiding this comment.
@MartijnCuppens Thanks a lot, this is a good move IMO.
I'd change enable-hand-cursor-for-buttons to enable-pointer-cursor-for-buttons, what do you think?
|
@andresgalante yup, good catch...technically more accurate to say |
|
No problem, just changed it to |
|
👍 ... @mdo what say you? |
|
@mdo: ping for review |
mdo
left a comment
There was a problem hiding this comment.
Current selectors include :not(.disabled) as well as the disabled attribute. I don't think we can consolidate all these under a single attribute selector, nor can we move away from the component classes completely I'd think since many, if not most, of these apply to anchors as well.
|
Isn't this going to be available in v4.2? |
c070acf to
c18e244
Compare
@mdo , this change won't affect the links, they will still have |
andresgalante
left a comment
There was a problem hiding this comment.
I think we should move this forward
Fixes #26998, fixes #22693
$enable-hand-cursor-for-buttonsvariable which allows developers to still use the default cursor for all buttons.scss/_reboot.scss.Closes #25598