Skip to content

Move hand cursor for buttons to reboot#27021

Merged
XhmikosR merged 3 commits intotwbs:v4-devfrom
MartijnCuppens:btn-hand-cursor
Jan 4, 2019
Merged

Move hand cursor for buttons to reboot#27021
XhmikosR merged 3 commits intotwbs:v4-devfrom
MartijnCuppens:btn-hand-cursor

Conversation

@MartijnCuppens
Copy link
Copy Markdown
Member

@MartijnCuppens MartijnCuppens commented Aug 5, 2018

Fixes #26998, fixes #22693

  • This PR adds a hand cursor for all buttons
  • Adds $enable-hand-cursor-for-buttons variable which allows developers to still use the default cursor for all buttons.
  • Adds a reset button example to the reboot page
  • Moved all the separated declarations to scss/_reboot.scss.

Closes #25598

Copy link
Copy Markdown
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks tidy to me (though I bet people still won't be happy, or start asking why we're not doing it for generic .btn applied to arbitrary elements as well...)

@ysds
Copy link
Copy Markdown
Contributor

ysds commented Aug 7, 2018

similar PR and discussion in #25598

Copy link
Copy Markdown
Collaborator

@andresgalante andresgalante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartijnCuppens Thanks a lot, this is a good move IMO.
I'd change enable-hand-cursor-for-buttons to enable-pointer-cursor-for-buttons, what do you think?

@patrickhlauke
Copy link
Copy Markdown
Member

@andresgalante yup, good catch...technically more accurate to say enable-pointer-cursor... (though i wonder if devs will be confused/not know that pointer in CSS actually results in the "hand")

Comment thread scss/_reboot.scss Outdated
Comment thread scss/_variables.scss Outdated
Comment thread site/docs/4.1/getting-started/theming.md Outdated
@MartijnCuppens
Copy link
Copy Markdown
Member Author

No problem, just changed it to $enable-pointer-cursor-for-buttons.

@patrickhlauke
Copy link
Copy Markdown
Member

👍 ... @mdo what say you?

Comment thread scss/_reboot.scss Outdated
@XhmikosR
Copy link
Copy Markdown
Member

@mdo: ping for review

Copy link
Copy Markdown
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current selectors include :not(.disabled) as well as the disabled attribute. I don't think we can consolidate all these under a single attribute selector, nor can we move away from the component classes completely I'd think since many, if not most, of these apply to anchors as well.

@jacobmllr95
Copy link
Copy Markdown
Contributor

Isn't this going to be available in v4.2?

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner December 7, 2018 15:24
@MartijnCuppens
Copy link
Copy Markdown
Member Author

Current selectors include :not(.disabled) as well as the disabled attribute. I don't think we can consolidate all these under a single attribute selector, nor can we move away from the component classes completely I'd think since many, if not most, of these apply to anchors as well.

@mdo , this change won't affect the links, they will still have cursor: pointer unless a class .disabled is added to a.btn. The only thing this will change is that the button (and input buttons) will have cursor:pointer by default.

Copy link
Copy Markdown
Collaborator

@andresgalante andresgalante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move this forward

@mdo mdo mentioned this pull request Jan 4, 2019
@XhmikosR XhmikosR merged commit b478234 into twbs:v4-dev Jan 4, 2019
@MartijnCuppens MartijnCuppens deleted the btn-hand-cursor branch January 4, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants