Skip to content

Add breadbrumb in docs search results#27115

Merged
XhmikosR merged 1 commit intotwbs:v4-devfrom
MartijnCuppens:improve-search-results
Aug 25, 2018
Merged

Add breadbrumb in docs search results#27115
XhmikosR merged 1 commit intotwbs:v4-devfrom
MartijnCuppens:improve-search-results

Conversation

@MartijnCuppens
Copy link
Copy Markdown
Member

@MartijnCuppens MartijnCuppens commented Aug 21, 2018

Make the subcategory visable and theme it like a breadcrumb. Made some screenshots which makes it easier to compare.

List

See original issue (#23389), it was not clear from where the list pages came from.

List before:

List after:

Left

This is just an example how it is displayed if the highlighted text is in the text and not in the title

Left before:

Left after:

Alert

Without breadcrumb it was not clear why some results showed up.

Alert before:

Alert after:

Closes #23389

Copy link
Copy Markdown
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks!

@XhmikosR
Copy link
Copy Markdown
Member

@mdo: please have a quick look before we merge.

@XhmikosR XhmikosR merged commit 8073e10 into twbs:v4-dev Aug 25, 2018
@mdo mdo mentioned this pull request Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants