Skip to content

Move hovered badge's text-decoration CSS to base styles#27149

Merged
mdo merged 1 commit intotwbs:v4-devfrom
ysds:badge-hover-underline
Sep 2, 2018
Merged

Move hovered badge's text-decoration CSS to base styles#27149
mdo merged 1 commit intotwbs:v4-devfrom
ysds:badge-hover-underline

Conversation

@ysds
Copy link
Copy Markdown
Contributor

@ysds ysds commented Aug 29, 2018

Each color does not need to have the text-decoration CSS. It should be defined in the base styles.

This change greatly expands color flexibility:

image

<a href="#" class="badge text-white bg-primary">Primary</a>
<a href="#" class="badge text-primary bg-transprent border border-primary">Outlined</a>
<a href="#" class="badge text-white" style="background-color: #1dcaff">Twitter</a>
<a href="#" class="badge text-white" style="background-color: #3b5998">Facebook</a>
<a href="#" class="badge text-white" style="background-color: #563d7c">Bootstrap</a>
<a href="#" class="badge text-white" style="background-color: #563D7C">css</a>
<a href="#" class="badge text-body" style="background-color: #FFC40D">js</a>

Demo: https://codepen.io/anon/pen/bxBBZa

Related: #23886, #27136 and the comment in the v5 ideas:

Improve components by removing all their most commonly overridden properties, thus relying more on utilities. ...

@mdo mdo merged commit d1de873 into twbs:v4-dev Sep 2, 2018
@mdo mdo mentioned this pull request Sep 2, 2018
@ysds ysds deleted the badge-hover-underline branch November 4, 2018 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants