feat: keep contrast on .table-dark#27160
Merged
XhmikosR merged 4 commits intotwbs:v4-devfrom Oct 19, 2018
Merged
Conversation
Member
|
I think I'm good with this. The dark styles aren't straight up inverse/reverse of our body styles like some other places. Thoughts @andresgalante? |
XhmikosR
approved these changes
Sep 13, 2018
zalog
force-pushed
the
zalog-vars-table
branch
2 times, most recently
from
e1a18c2 to
c97664f
Compare
In case we set `$body-bg` to a dark color, we have to keep table contrast relevant.
zalog
force-pushed
the
zalog-vars-table
branch
from
c97664f to
4f2c261
Compare
Member
|
@MartijnCuppens: LGTY? |
Closed
Contributor
Author
|
Tnks for your time, guys. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case we change
$body-bgto a dark color, we have to keep table contrast relevant.