Conversation
|
You chose the wrong target, your PR should target : |
|
Hmm no I made a mistake you targeted the right branch, but your local branch is outdated |
|
Can you rebase your branch please ? Or can you create a new PR from Because currently I can't merge your PR because of there are irrelevant commits |
992c37a to
a188bd5
Compare
|
How's this looking now? =) |
Johann-S
left a comment
There was a problem hiding this comment.
you have to use git rebase to update your local branch
d8c209f to
a188bd5
Compare
Can you clarify what you want? I thought I did this but looks like I'm wrong. Forking is new to me so will need more guidance |
|
@aTable if you followed this to create your PR: https://github.com/twbs/bootstrap/blob/v4-dev/.github/CONTRIBUTING.md#pull-requests You created a git pull upstream v4-without-jquery --rebase |
bc00e49 to
c37ae5c
Compare
a188bd5 to
4572c0c
Compare
|
Rebased |
4572c0c to
f012bfd
Compare
|
The assistance is much appreciated. Thanks |


I was using the updated Alert docs as a guide and modernized the button, carousel and collapsible JavaScript docs.
Working my way through them so I thought I'd create this PR to track progress