Custom select validation tweaks#27175
Conversation
There was a problem hiding this comment.
I wonder if we take the opportunity to clean this up a bit here and turn these major values into variables? Separately, was the / working as intended before? Curious if Sass was trying to compute this vs keeping it as a property separator.
There was a problem hiding this comment.
A calc() function was used, that's why the / worked before.
Do you want to use the variables in the _variables.scss file or declare them here in the _forms.scss?
There was a problem hiding this comment.
Ah, yeah, got it. Most likely in _variables.scss.
|
@MartijnCuppens: can you move the variable to _variables.scss? |
|
Tests are failing for linter issues. |
…dback icon variables
6896add to
3693246
Compare
|
I've moved some values to the variables file as mdo suggested and simplified the |
The padding of custom selects doesn't cover the background, if the text in the select box is to long, the text and background image will overlap.
This PR also removes unneeded
calc()functions.Before:

After:
