Move media from layout to components#27206
Merged
XhmikosR merged 3 commits intotwbs:v4-devfrom Oct 17, 2018
Merged
Conversation
Member
|
Just a note, if we are going with this, we need to add a redirect too. |
Member
Author
|
@XhmikosR, I was also thinking about this, but if this is going to be changed in 4.2 and not in 4.1, it won't be necessary since we only add urls and not change them? |
Member
|
True, but this is a fairly new scheme. And I'd rather err on the non-broken pages around the web :) So, if this is going to be merged in a new minor version, I guess we don't need the redirect. |
XhmikosR
approved these changes
Sep 13, 2018
Member
|
@mdo: are you OK with this? |
Member
|
Eh, I'm not strongly attached to one direction over the other. For context, I don't see |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @ysds, move the media page from layout to components
media-object.mdfile tocomponentsfoldermedia-objectpage in links in the docs (but there is also a test for 404 links which covers this, I just realised this while I'm writing this 🙂)Closes #27165