Skip to content

Remove background-colors example and show only the code.#27209

Merged
XhmikosR merged 3 commits intov4-devfrom
v4-dev-xmr-docs-gradients
Sep 17, 2018
Merged

Remove background-colors example and show only the code.#27209
XhmikosR merged 3 commits intov4-devfrom
v4-dev-xmr-docs-gradients

Conversation

@XhmikosR
Copy link
Copy Markdown
Member

This is to avoid confusion.

Fixes #27068

@mdo
Copy link
Copy Markdown
Member

mdo commented Sep 13, 2018

Should we be more explicit in the docs and make a note that says these don't have a live example because they're purposefully disabled by default?

@XhmikosR
Copy link
Copy Markdown
Member Author

We could but as it seems no one reads the bold text :)

Feel free to push here any tweaks.

Copy link
Copy Markdown
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes to the copy, should be good now.

@mdo mdo mentioned this pull request Sep 17, 2018
@XhmikosR XhmikosR merged commit 301a22b into v4-dev Sep 17, 2018
@XhmikosR XhmikosR deleted the v4-dev-xmr-docs-gradients branch September 17, 2018 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants