Skip to content

Selector improvement linked badge#27219

Merged
andresgalante merged 1 commit intotwbs:v4-devfrom
MartijnCuppens:badge-selector
Sep 14, 2018
Merged

Selector improvement linked badge#27219
andresgalante merged 1 commit intotwbs:v4-devfrom
MartijnCuppens:badge-selector

Conversation

@MartijnCuppens
Copy link
Copy Markdown
Member

Selector improvement, isolated from PR #27136

a.badge instead of .badge[href]

@XhmikosR
Copy link
Copy Markdown
Member

@MartijnCuppens: could you try if the Sass gem builds everything right too?

@MartijnCuppens
Copy link
Copy Markdown
Member Author

@XhmikosR I've run the command sass scss/bootstrap.scss:dist/css/bootstrap.css this also returns the expected result, was this what you wanted to be tested?

@XhmikosR
Copy link
Copy Markdown
Member

Yup, all good thanks!

Copy link
Copy Markdown
Collaborator

@andresgalante andresgalante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MartijnCuppens 😄

@andresgalante andresgalante merged commit 7a01f3c into twbs:v4-dev Sep 14, 2018
@mdo mdo mentioned this pull request Sep 14, 2018
@MartijnCuppens MartijnCuppens deleted the badge-selector branch September 16, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants