Merged
Conversation
XhmikosR
force-pushed
the
v4-dev-xmr-docs-js-bundle
branch
from
eff60ef to
39dc1a8
Compare
Member
|
IMO we did it to talk about our bundle file everywhere in our docs 🤔 |
Johann-S
approved these changes
Sep 17, 2018
XhmikosR
changed the title
Member
Author
|
Let's wait for one more approval then. :) |
mdo
approved these changes
Sep 17, 2018
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
I'm fine with this. No strong feelings one way or another.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is WIP because we probably need to go through the docs and make sure we list/suggest the bundle everywhere