refine deprecated holder.js color syntax#27400
Merged
XhmikosR merged 1 commit intotwbs:v4-devfrom Oct 11, 2018
Merged
Conversation
Member
|
Is this the only case? |
Member
|
Please check the preview, it seems broken here https://deploy-preview-27400--twbs-bootstrap4.netlify.com/docs/4.1/components/card/#image-overlays |
XhmikosR
requested changes
Oct 11, 2018
Member
XhmikosR
left a comment
XhmikosR
left a comment
There was a problem hiding this comment.
Please revert the p removal.
* refine deprecated holder.js color syntax * remove `#55595c:#373a3c` * harmonize with all other holder.js examples
m5o
force-pushed
the
holder-js-remove-deprecated-text-color
branch
from
bb5450b to
872a5f5
Compare
Contributor
Author
yes |
XhmikosR
approved these changes
Oct 11, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#55595c:#373a3cwhich is only used once