Merged
Conversation
XhmikosR
force-pushed
the
v4-dev-xmr-various
branch
from
584c60c to
1ec6f28
Compare
XhmikosR
force-pushed
the
v4-dev-xmr-various
branch
2 times, most recently
from
76f65a6 to
4da997e
Compare
Member
Author
|
@Johann-S: shouldn't we have a test which we expect to fail with invalid selectors? |
XhmikosR
force-pushed
the
v4-dev-xmr-various
branch
2 times, most recently
from
6d46bf8 to
73177ce
Compare
Member
Johann-S
approved these changes
Oct 13, 2018
Member
Author
Member
|
Yep but we don't test our documentation in our unit test |
Member
Author
|
That's not in the docs though, that's in tests. |
XhmikosR
force-pushed
the
v4-dev-xmr-various
branch
3 times, most recently
from
3e5a0d2 to
3943f00
Compare
Also, remove popper.js from this script since it's not present in the repo.
* fix `/versions/` link * add missing trailing slashes * fix a couple of redirects
Broken after 787441d.
XhmikosR
force-pushed
the
v4-dev-xmr-various
branch
from
1177201 to
1c33cea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The popper.js situation is something we need to find a solution for, because we will definitely hit it again... We need a way to be in sync.