Fix form-validation-state() for unknown pseudo classes#27409
Closed
tkrotoff wants to merge 2 commits intotwbs:v4-devfrom
Closed
Fix form-validation-state() for unknown pseudo classes#27409tkrotoff wants to merge 2 commits intotwbs:v4-devfrom
tkrotoff wants to merge 2 commits intotwbs:v4-devfrom
Conversation
Contributor
Author
|
A better PR has been already proposed and closed: #26471 |
Member
|
Thanks, but still inclined to leave this out of v4. I still don't see enough value in warning users of something that's not invalid and not valid. Other states just seem like they'd add confusion. Thanks again though! |
Contributor
Author
It's not about adding other states to Bootstrap itself. It's about removing a limitation for the ecosystem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #23371, see also Stack Overflow - Bootstrap 4, is-pending form validation state
Make things like
@include form-validation-state("warning", ...)possible:$statecan now be anything not justvalidandinvalid.It changes nothing for
validandinvalid: the CSS output is exactly the same.Output for
@include form-validation-state("warning", ...)::warningis an unknown pseudo class => the browser will ignore the whole line):warningreplaced by.is-warning=> no impact)