calculate modal transition duration based on modal-dialog element#27521
Merged
calculate modal transition duration based on modal-dialog element#27521
Conversation
Johann-S
force-pushed
the
v4-dev-jo-fix-modal
branch
2 times, most recently
from
582ef2d to
74c638a
Compare
Johann-S
force-pushed
the
v4-dev-jo-fix-modal
branch
from
74c638a to
a099be9
Compare
XhmikosR
approved these changes
Oct 28, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We get the transition duration from the wrong element (
.modal) but we wait for thetransitionendevent of.modal-dialogso we calledemulateTransitionEnd.Fixes: #27519