Conversation
|
Now that I think about it... The header levels for some of the includes don't make sense. They show as children in ToC. The thing is we can't know the level of the previous sibling item and thus use the same level in the callouts. So, perhaps we should just hide the callouts' headers consistently? |
|
nobody dies if a heading level is skipped. unless we have a way to embed callouts at any level, and the callout auto-adapts the level to be subordinate of the last heading level it's at, it's safest to keep the heading level to something guaranteed to be subordinate in every situation...so let's leave it to |
|
The reason for this PR wasn't the skipped level. Was to show the callout in the ToC. But after thinking about it, I believe it's better if we just hide all callouts instead from ToC. |
patrickhlauke
left a comment
There was a problem hiding this comment.
if we can guarantee that the callout is only ever included with a preceding h3, and not an h4 or h5, then sure. but i think it's not a major problem even as is.
|
ah gotcha,hadn't seen your comment until now. yeah, i think it's fine even if the callouts AREN'T in the TOC |
|
All right, I'm gonna hide them by using an |
h4 for the accessibility callouth5 for callouts
|
Actually, it might be a bug in jekyll-toc. Waiting for confirmation/fix toshimaru/jekyll-toc#70 |
|
Thanks but I want this fixed upstream. |
233f175 to
9e74183
Compare
|
FWIW, I don’t want callouts to be listed in the table of contents. Any of them that are there currently are there unintentionally. |
|
Yeah, I think I will just change them so that they don't show up for now. No idea when this will be fixed upstream. |
1fdef2d to
f6cda5e
Compare
Callouts are already excluded from ToC, but due to a limitation in jekyll-toc they are still being included. We should revisit this if the bug is fixed later.
f6cda5e to
7074a2d
Compare
This is so that they are not included in ToC.