Update grid doc for consistent use of container wrapper.#27776
Merged
XhmikosR merged 2 commits intotwbs:v4-devfrom Dec 16, 2018
Merged
Update grid doc for consistent use of container wrapper.#27776XhmikosR merged 2 commits intotwbs:v4-devfrom
XhmikosR merged 2 commits intotwbs:v4-devfrom
Conversation
florianlacreuse
commented
Dec 5, 2018
| <div class="row mx-lg-n5"> | ||
| <div class="col py-3 px-lg-5 border bg-light">Custom column padding</div> | ||
| <div class="col py-3 px-lg-5 border bg-light">Custom column padding</div> | ||
| <div class="container px-lg-5"> |
Contributor
Author
There was a problem hiding this comment.
I'm not sure about this one, may be we don't want to talk about .container here?
Member
There was a problem hiding this comment.
On gigantic screens or when you're zoomed out a lot you'll see that this class will align this example with the rest, you can keep it here.
MartijnCuppens
approved these changes
Dec 7, 2018
Member
MartijnCuppens
left a comment
MartijnCuppens
left a comment
There was a problem hiding this comment.
I like this, this keeps the examples aligned. Nice job @florianlacreuse!
Contributor
Author
|
@MartijnCuppens Thanks! I hope this will be merged for the next v4.2 coming soon. |
mdo
approved these changes
Dec 16, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the grid section of the documentation, some examples use
.containerparent class and some don't. This may be confusing for new users. Furthermore, not all examples are aligned in the same way (since the missing paddings).