Merged
Conversation
pull from official package
merge official
- changed gutter definition - changed left and padding left on the custom checkboxes and radios
MartijnCuppens
approved these changes
Dec 7, 2018
Member
MartijnCuppens
left a comment
MartijnCuppens
left a comment
There was a problem hiding this comment.
This LGTM because the variable name now represents what is does.
Contributor
Author
|
this might introduce a breaking change for people that use the sass source code. though i doubt they would use this variable. |
Member
|
Indeed. But maybe we should document this in the release notes? @mdo, what do you think? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
$custom-control-gutterdefines the gutter + the indicator size. This works great if the indicator is the same size for each custom control that uses this variable. While working on the switch element in #23004 i realized that i had to do weird calculations to get the same gutter as for the radio and checkbox. The actual gutter is .5rem, but is now 1.5rem. This PR changes that so the gutter variable is actually the space between the indicator and the label.