Workaround for MS Edge does not update disabled control's style#28275
Merged
XhmikosR merged 4 commits intotwbs:masterfrom Mar 17, 2019
Merged
Workaround for MS Edge does not update disabled control's style#28275XhmikosR merged 4 commits intotwbs:masterfrom
XhmikosR merged 4 commits intotwbs:masterfrom
Conversation
Member
|
@MartijnCuppens I haven't tested or reviewed this myself, but likely a candidate for v4 and then bringing back into v5. |
MartijnCuppens
approved these changes
Feb 16, 2019
Member
MartijnCuppens
left a comment
There was a problem hiding this comment.
I really dislike the attribute selector but if it's the only solution we should do this. We'll revert this again once Edge has switched to Chromium.
Member
|
Does the attribute selector cover the psuedo class for all browsers? |
Contributor
Author
|
The
|
Member
|
Changed the base branch to master. If it's supposed to be backported in 4.x, mark it or something and we'll cherry pick it when we cut the release. |
XhmikosR
pushed a commit
that referenced
this pull request
Mar 18, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Mar 21, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Mar 27, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28247
Before: https://codepen.io/anon/pen/VgEmwV
After: https://codepen.io/anon/pen/PVyGLv
This PR targets the components of the Bootstrap. However, if bootstrap team prefer to fix every situation, it can also add the following CSS to the
_reboot.scss.[disabled] ~ _ {}