Conversation
Contributor
|
Please check the first demo on a button :) https://github.com/twbs/bootstrap/pull/28458/files#diff-f61d8731574dae0fcf82be95eabcf9f5R27
- Notifications <span class="badge badge-light">4</span>
+ Notifications <span class="badge bg-secondary">4</span> |
13 tasks
- Drop hover and focus states - Drop .badge-* variants and associated mixin for .bg-* utilities - Drop .badge-pill for .rounded-pill utliity and adjust horizontal padding to find middle ground of .badge and old .badge-pill - Remove unused variables - Add default color value to .badge base class - Update docs to reflect changes
Member
Author
|
This should be ready for review @twbs/css-review. Thanks @XhmikosR for rebasing! |
MartijnCuppens
approved these changes
Mar 14, 2019
Member
MartijnCuppens
left a comment
MartijnCuppens
left a comment
There was a problem hiding this comment.
Way better! I was thinking about combining the .btns and .badges into one component, but we'll get in trouble with the hover states if we do that.
XhmikosR
added a commit
that referenced
this pull request
Aug 3, 2019
XhmikosR
added a commit
that referenced
this pull request
Aug 4, 2019
lucanos
pushed a commit
to lucanos/bootstrap
that referenced
this pull request
Oct 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass at updating the badge component per discussions in #27136, other threads, and our team Slack channel. Here's what's included thus far:
.badge-*variants and associated mixin for.bg-*utilities.badge-pillfor.rounded-pillutility and adjust horizontal padding to find middle ground of.badgeand old.badge-pillcolorvalue to.badgebase class