Conversation
Merged
coliff
suggested changes
Mar 17, 2019
Contributor
coliff
left a comment
There was a problem hiding this comment.
The script in this PR isn't loading async and is slower than the one used in production now. I would suggest change move to:
window.ga=window.ga||function(){(ga.q=ga.q||[]).push(arguments)};ga.l=+new Date;
ga('create', 'UA-146052-10', 'getbootstrap.com');
ga('set', 'anonymizeIp', true);
ga('send', 'pageview');
</script>
<script async src="https://www.google-analytics.com/analytics.js"></script>```
Member
Author
|
I don't see where you see it's not loaded async. The only change I did was to add the anonymize IP setting. So, it's whatever it was before. |
Contributor
|
ah, sorry- I had just quickly checked the first few diffs in this PR which were on the old Bootstrap 1.x docs which were/are using a much older analytics snippet so had wrongly assumed the same was used for all the docs. I think it's all good now 👍 |
Member
Author
|
Yeah, those are left as is for now, since, you know, it's just ancient docs. |
mdo
approved these changes
Mar 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.