Skip to content

GA: Anonymize IPs and use https.#28501

Merged
XhmikosR merged 2 commits intogh-pagesfrom
gh-pages-xmr
Mar 18, 2019
Merged

GA: Anonymize IPs and use https.#28501
XhmikosR merged 2 commits intogh-pagesfrom
gh-pages-xmr

Conversation

@XhmikosR
Copy link
Copy Markdown
Member

No description provided.

@XhmikosR XhmikosR added the docs label Mar 15, 2019
@XhmikosR XhmikosR requested a review from mdo March 15, 2019 08:05
@XhmikosR XhmikosR mentioned this pull request Mar 15, 2019
@XhmikosR XhmikosR marked this pull request as ready for review March 15, 2019 08:15
@XhmikosR XhmikosR changed the title GA: Anonymize IPs and use https for the GA script. GA: Anonymize IPs and use https. Mar 15, 2019
Copy link
Copy Markdown
Contributor

@coliff coliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script in this PR isn't loading async and is slower than the one used in production now. I would suggest change move to:

  window.ga=window.ga||function(){(ga.q=ga.q||[]).push(arguments)};ga.l=+new Date;
  ga('create', 'UA-146052-10', 'getbootstrap.com');
  ga('set', 'anonymizeIp', true);
  ga('send', 'pageview');
</script>
<script async src="https://www.google-analytics.com/analytics.js"></script>```

@XhmikosR
Copy link
Copy Markdown
Member Author

I don't see where you see it's not loaded async.

The only change I did was to add the anonymize IP setting. So, it's whatever it was before.

@coliff
Copy link
Copy Markdown
Contributor

coliff commented Mar 17, 2019

ah, sorry- I had just quickly checked the first few diffs in this PR which were on the old Bootstrap 1.x docs which were/are using a much older analytics snippet so had wrongly assumed the same was used for all the docs. I think it's all good now 👍

@XhmikosR
Copy link
Copy Markdown
Member Author

Yeah, those are left as is for now, since, you know, it's just ancient docs.

@XhmikosR XhmikosR merged commit ba08dab into gh-pages Mar 18, 2019
@XhmikosR XhmikosR deleted the gh-pages-xmr branch March 18, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants