Closed
Conversation
Member
|
Can we look at putting this in #28450? I haven’t had a ton of time to revisit that draft PR, so it might be gnarly, but it’s my intent to ship that in v5 and combine these two sets of components. I didn’t think to make them explicitly linked to line-height, but that PR got closer than the current ones in v4. |
Member
Author
It's not what I really prefer, but this seems to be the only solution to properly align the native checkboxes. This PR will have merge conflicts with #28450, maybe I shall just move the changes in reboot to that PR? |
Member
Author
|
Gonna close this since this PR introduces some issues when focus states are applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross browser aligning checkboxes and radios is hard because every browser seems to have different widths/height and align possibilities. This misaligns our checkboxes and radios in different ways.
I found a solution for this by setting the height of the input to the line height. This won't stretch the input but instead align it to the middle of the element which will perfectly align checkboxes and radios in every browser.
The only disadvantage is that the line height will depend on the line height of the body, but I think that's fine in almost any situation. The current situation is way worse imo.
Before:
After
Closes #27755