Skip to content

Align checkboxes & radios#28711

Closed
MartijnCuppens wants to merge 5 commits intomasterfrom
master-mc-checkbox-radio-align
Closed

Align checkboxes & radios#28711
MartijnCuppens wants to merge 5 commits intomasterfrom
master-mc-checkbox-radio-align

Conversation

@MartijnCuppens
Copy link
Copy Markdown
Member

@MartijnCuppens MartijnCuppens commented May 1, 2019

Cross browser aligning checkboxes and radios is hard because every browser seems to have different widths/height and align possibilities. This misaligns our checkboxes and radios in different ways.

I found a solution for this by setting the height of the input to the line height. This won't stretch the input but instead align it to the middle of the element which will perfectly align checkboxes and radios in every browser.

The only disadvantage is that the line height will depend on the line height of the body, but I think that's fine in almost any situation. The current situation is way worse imo.

Before:

After

Closes #27755

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner May 1, 2019 13:21
@mdo
Copy link
Copy Markdown
Member

mdo commented May 1, 2019

Can we look at putting this in #28450? I haven’t had a ton of time to revisit that draft PR, so it might be gnarly, but it’s my intent to ship that in v5 and combine these two sets of components. I didn’t think to make them explicitly linked to line-height, but that PR got closer than the current ones in v4.

@MartijnCuppens
Copy link
Copy Markdown
Member Author

I didn’t think to make them explicitly linked to line-height

It's not what I really prefer, but this seems to be the only solution to properly align the native checkboxes.

This PR will have merge conflicts with #28450, maybe I shall just move the changes in reboot to that PR?

@MartijnCuppens
Copy link
Copy Markdown
Member Author

Gonna close this since this PR introduces some issues when focus states are applied.

@XhmikosR XhmikosR deleted the master-mc-checkbox-radio-align branch November 2, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vertical alignment of radio/checkbox broken

3 participants