Skip to content

Fix reboot for placeholder links#29164

Merged
XhmikosR merged 1 commit intov4-dev-xmrfrom
v4-dev-reboot-placeholder-link
Jul 29, 2019
Merged

Fix reboot for placeholder links#29164
XhmikosR merged 1 commit intov4-dev-xmrfrom
v4-dev-reboot-placeholder-link

Conversation

@ysds
Copy link
Copy Markdown
Contributor

@ysds ysds commented Jul 29, 2019

#29162 have not backport #29140 completely.

@ysds ysds requested a review from a team as a code owner July 29, 2019 15:23
@patrickhlauke
Copy link
Copy Markdown
Member

ah darn, completely missed that. good catch @ysds

@ysds
Copy link
Copy Markdown
Contributor Author

ysds commented Jul 29, 2019

no worries 😄

@XhmikosR XhmikosR merged commit 2975371 into v4-dev-xmr Jul 29, 2019
@XhmikosR XhmikosR deleted the v4-dev-reboot-placeholder-link branch July 29, 2019 15:41
@XhmikosR
Copy link
Copy Markdown
Member

BTW you guys can push directly to open PR branches, no need for a PR.

@patrickhlauke
Copy link
Copy Markdown
Member

patrickhlauke commented Jul 29, 2019

even after they're merged though? [edit: oh you mean v4-dev-xmr itself, right?]

@XhmikosR
Copy link
Copy Markdown
Member

My v4-dev-xmr branch has a PR still open :P

XhmikosR pushed a commit that referenced this pull request Jul 30, 2019
XhmikosR pushed a commit that referenced this pull request Jul 30, 2019
XhmikosR pushed a commit that referenced this pull request Jul 31, 2019
XhmikosR pushed a commit that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants