V4: Add :disabled for disabled fieldset#29762
Merged
XhmikosR merged 2 commits intov4-dev-xmrfrom Nov 28, 2019
Merged
Conversation
Member
|
@ysds does this apply to master too or only v4? |
Contributor
Author
|
Only v4! |
Member
|
Hmm, then we need @MartijnCuppens and @mdo to review too. |
MartijnCuppens
approved these changes
Nov 28, 2019
Member
|
If we're going to include this in 4.4.1, we'll need to update our blogpost a bit |
Member
|
If you guys think it's safe, we can include it since have the patch ready. |
Member
|
I think we're save with this one |
Member
|
I've added this in twbs/blog#123 |
XhmikosR
pushed a commit
that referenced
this pull request
Nov 28, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Nov 28, 2019
This was referenced Dec 7, 2019
This was referenced Mar 4, 2020
This was referenced Mar 27, 2020
This was referenced Apr 4, 2020
Merged
This was referenced Apr 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is #29740 for v4, targets the
v4-dev-xmrbranch.Before (4.4.0): https://codepen.io/fellows3/pen/LYYwejp
After: https://codepen.io/fellows3/pen/pooMpWQ