Skip to content

Fix: avoid ignore plain text in input-group-$size#29803

Closed
mendozagioo wants to merge 1 commit intotwbs:v4-devfrom
mendozagioo:v4-dev
Closed

Fix: avoid ignore plain text in input-group-$size#29803
mendozagioo wants to merge 1 commit intotwbs:v4-devfrom
mendozagioo:v4-dev

Conversation

@mendozagioo
Copy link
Copy Markdown
Contributor

@mendozagioo mendozagioo commented Dec 4, 2019

Fixes #29605

@mendozagioo mendozagioo requested a review from a team as a code owner December 4, 2019 21:03
@MartijnCuppens
Copy link
Copy Markdown
Member

Issue: https://codepen.io/MartijnCuppens/pen/dyPoOKM
Fix: https://codepen.io/MartijnCuppens/pen/KKwpNBx

It seems the inputs aren't aligned due to the border. Is this issue also present in master?

@ysds
Copy link
Copy Markdown
Contributor

ysds commented Dec 5, 2019

@MartijnCuppens Dropped in #28972

@mendozagioo
Copy link
Copy Markdown
Contributor Author

Hey @MartijnCuppens, in master branch is worst, the input is out of line. The problem here is that form-control-plaintext class is considered just for remove border and color but not is considered to use like child of input-group class. The fix, just it add form-control-plaintext class to be used inside of input-group class

@MartijnCuppens
Copy link
Copy Markdown
Member

This PR need some additional tweaks to fix the issues with the border. Not sure if it's worth fixing this if we drop this if we drop this in master anyway.

\CC @twbs/css-review

@mdo
Copy link
Copy Markdown
Member

mdo commented Feb 15, 2020

This PR need some additional tweaks to fix the issues with the border. Not sure if it's worth fixing this if we drop this if we drop this in master anyway.

It is indeed not worth it :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants