package.json: remove engines property#29908
Merged
Conversation
This property doesn't, or shouldn't, affect consumers of the npm package since we distribute the built files
MartijnCuppens
approved these changes
Dec 25, 2019
Merged
Member
Author
Member
|
I don't think it'll break something we do not publish a Node.js package, we are a frontend framework so it's totally fine to me 👍 |
Johann-S
approved these changes
Jan 7, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
This property doesn't, or shouldn't, affect consumers of the npm package since we distribute the built files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This property doesn't, or shouldn't, affect consumers of the npm package since we distribute the built files.
IMO we should definitely backport this to v4-dev, that's the whole point, but it could be considered a breaking change, although I don't see exactly how. So, please chime in if you think this could break something out there.
Closes #29821
TODO: