Use regex.test() when we want to check for a Boolean.#29969
Merged
Conversation
Johann-S
reviewed
Jan 7, 2020
| if (tabClass !== null && tabClass.length) { | ||
| tabClass | ||
| .map(token => token.trim()) | ||
| if (tabClass !== null && tabClass.length > 0) { |
Member
There was a problem hiding this comment.
tabClass.length is equal too tabClass.length > 0 not really needed that change
Member
Author
There was a problem hiding this comment.
It's what we do in popover.js; this code is exactly the same
Member
There was a problem hiding this comment.
So we can change that in popover.js too 😄 but it's nitpicking
Member
Author
There was a problem hiding this comment.
Fine by me, I'd just prefer if we enforced this with a rule, but I cannot find one, only for the opposite unicorn/explicit-length-check
Johann-S
approved these changes
Jan 7, 2020
Member
Johann-S
left a comment
Johann-S
left a comment
There was a problem hiding this comment.
LGTM 👍
I don't think it's really needed to backport that
XhmikosR
added a commit
that referenced
this pull request
Jan 23, 2020
XhmikosR
added a commit
that referenced
this pull request
Feb 4, 2020
XhmikosR
added a commit
that referenced
this pull request
Feb 16, 2020
XhmikosR
added a commit
that referenced
this pull request
Feb 17, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
…n. (twbs#29969)" (twbs#30770) This partially reverts commit 9c2b9ac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if we should backport this