Close modal with keyboard=true & backdrop=static#29986
Merged
XhmikosR merged 3 commits intotwbs:masterfrom Jan 10, 2020
Merged
Conversation
Johann-S
approved these changes
Jan 9, 2020
Member
Johann-S
left a comment
Johann-S
left a comment
There was a problem hiding this comment.
Nice PR thanks @mendozagioo 👍
MartijnCuppens
approved these changes
Jan 9, 2020
Member
MartijnCuppens
left a comment
MartijnCuppens
left a comment
There was a problem hiding this comment.
Seems to work fine, thanks!
Member
|
Thanks for the patch @mendozagioo! @Johann-S this will need to be manually backported to my v4-dev-xmr branch when you have some time :) |
Member
|
@mendozagioo can you please backport this to my v4-dev-xmr branch? |
XhmikosR
pushed a commit
that referenced
this pull request
Feb 12, 2020
Close modal with keyboard=true & backdrop=static (#29986) * Close modal with keyboard=true & backdrop=static
mendozagioo
added a commit
to mendozagioo/bootstrap
that referenced
this pull request
Feb 16, 2020
* According to twbs#29986
Contributor
Author
|
@XhmikosR, I added the appropriate tests |
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
* Close modal with keyboard=true & backdrop=static
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoid the no close of modal with options:
fix issue: #29978
Preview: https://deploy-preview-29986--twbs-bootstrap.netlify.com/docs/4.3/components/modal/#static-backdrop