Nested list-group-horizontal in list-group-flush border fix#30039
Closed
PDerid wants to merge 3 commits intotwbs:masterfrom
PDerid:nested-list-groups-border-fix
Closed
Nested list-group-horizontal in list-group-flush border fix#30039PDerid wants to merge 3 commits intotwbs:masterfrom PDerid:nested-list-groups-border-fix
PDerid wants to merge 3 commits intotwbs:masterfrom
PDerid:nested-list-groups-border-fix
Conversation
MartijnCuppens
changed the title
MartijnCuppens
requested changes
Jan 18, 2020
Member
MartijnCuppens
left a comment
MartijnCuppens
left a comment
There was a problem hiding this comment.
Card kitchen sink example is broken by this change:
https://deploy-preview-30039--twbs-bootstrap.netlify.com/docs/4.3/components/card/#kitchen-sink
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added styles only to the top level element of the list.
Removed following lines:
bootstrap/scss/_list-group.scss
Lines 145 to 149 in dfc1149
and added the border width of 0 to the last
.list-group-itemchild.closes #30027
closes #27126 because the double border does not occur in the code update.
Netlify link