Skip to content

Fix file input#30086

Merged
XhmikosR merged 1 commit intomasterfrom
master-mc-fix-file-input
Jan 25, 2020
Merged

Fix file input#30086
XhmikosR merged 1 commit intomasterfrom
master-mc-fix-file-input

Conversation

@MartijnCuppens
Copy link
Copy Markdown
Member

@MartijnCuppens MartijnCuppens commented Jan 25, 2020

@XhmikosR
Copy link
Copy Markdown
Member

When did this break exactly? Just to double check things.

@MartijnCuppens
Copy link
Copy Markdown
Member Author

MartijnCuppens commented Jan 25, 2020

We switched from a pseudo element button to a .form-file-button and forgot to adjust the documentation here. (#28696)

@XhmikosR
Copy link
Copy Markdown
Member

Can you check if there are more cases?

@MartijnCuppens
Copy link
Copy Markdown
Member Author

I did (searched for custom-file occurrences and this was the only place we missed)

@XhmikosR XhmikosR merged commit 3350931 into master Jan 25, 2020
@XhmikosR XhmikosR deleted the master-mc-fix-file-input branch January 25, 2020 13:58
@XhmikosR
Copy link
Copy Markdown
Member

BTW it would be nice if you referenced the commit or PR something broke in the future :)

olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants