Skip to content

V5 form validations #30170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ysds wants to merge 6 commits into from
Closed

V5 form validations #30170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a1f6370
Drop feedback message by sibling selector
ysds Mar 17, 2020
99775f9
Rewrite supported, feedback message and tooltip docs
ysds Mar 17, 2020
754362e
Associate validation feedbacks with their form
ysds Mar 17, 2020
4c53d0b
Restore missing aria-label, add missing end of file line
mdo Jun 15, 2020
a038d24
Fix JS linter
mdo Jun 15, 2020
e4757c7
Merge branch 'main' into master-ysds-form-validations
XhmikosR Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions scss/mixins/_forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@

@mixin form-validation-state($state, $color, $icon) {
.#{$state}-feedback {
display: none;
width: 100%;
margin-top: $form-feedback-margin-top;
@include font-size($form-feedback-font-size);
font-style: $form-feedback-font-style;
Expand All @@ -27,7 +25,6 @@
position: absolute;
top: 100%;
z-index: 5;
display: none;
max-width: 100%; // Contain to parent when possible
padding: $form-feedback-tooltip-padding-y $form-feedback-tooltip-padding-x;
margin-top: .1rem;
Expand All @@ -38,13 +35,6 @@
@include border-radius($form-feedback-tooltip-border-radius);
}

@include form-validation-state-selector($state) {
~ .#{$state}-feedback,
~ .#{$state}-tooltip {
display: block;
}
}

.form-control {
@include form-validation-state-selector($state) {
border-color: $color;
Expand Down
Loading