Skip to content

Remove unnecessary reduce motion when $enable-transition: false#30183

Merged
XhmikosR merged 2 commits intomasterfrom
master-ysds-unnecessary-reduce-motion
Feb 17, 2020
Merged

Remove unnecessary reduce motion when $enable-transition: false#30183
XhmikosR merged 2 commits intomasterfrom
master-ysds-unnecessary-reduce-motion

Conversation

@ysds
Copy link
Copy Markdown
Contributor

@ysds ysds commented Feb 15, 2020

When $enable-transition: false,

@media (prefers-reduced-motion: reduce) {
   transition: none;
}

is unnecessary.

@ysds ysds requested a review from a team as a code owner February 15, 2020 12:57
@XhmikosR
Copy link
Copy Markdown
Member

@ysds don't forget to add the projects in the PRs :)

@XhmikosR
Copy link
Copy Markdown
Member

If this is supposed to be backported to v4, we need the 4.4.2 project too.

@XhmikosR
Copy link
Copy Markdown
Member

Any reason why not include this in alpha-1 and 4.4.2 subsequently?

@ysds
Copy link
Copy Markdown
Contributor Author

ysds commented Feb 17, 2020

I think this a minor bug. To speed up the release of Alpha1, I targeted this to Alpha2 not to increase our review work, but now the review was completed it is fine to include this in Alpha1.

I forgot to put it in 4.4.2 ^^;

@XhmikosR XhmikosR merged commit 8087272 into master Feb 17, 2020
@XhmikosR XhmikosR deleted the master-ysds-unnecessary-reduce-motion branch February 17, 2020 07:46
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants