$link-decoration: underline affects some components

[arthurshlain]

Removed redundant text-decoration when element is link with .btn class (a.btn) and $link-decoration variable is set to 'underline'.

.btn-link also works with this fix, because .btn-link declaration located below.

Upd.

Fixed text-decoration for:

• .btn (except .btn-link)
• .dropdown-item
• .list-group-item
• .page-link (looks like button)
• .nav-link

[ysds]

Nice catch!

[ysds]

I'm wondering if this should be applied to other components.

[arthurshlain]

I know same behavior exist with pagination elements.
Also 'underline' applied to .navbar-brand, but it's maybe ok...

[MartijnCuppens]

I would prefer an if test to prevent generation of the property if not needed. Something like:

text-decoration: if($link-decoration == none, null, none);

(code not tested)

[arthurshlain]

(code not tested)

It's works good

[arthurshlain]

.nav-link looks normal by default, except .active state.

Remove underline for any .nav-link or only for .active state?

[MartijnCuppens]

Remove underline for any .nav-link or only for .active state?

I would just make sure the nav links look the same like in the current docs:

Dismiss

[arthurshlain]

Something wrong with this fix now?

[ysds]

LGTM

[patrickhlauke]

this closed #15304 but note that one of the scenarios is still there...alerts with links and strong text (mocked up here by taking one of the alerts in the docs and adding an <a href="#" class="alert-link">...</a> in there)

[MartijnCuppens]

Didn't notice this was added, I've reopened #15304.