v5 tabs - accessibility issue when using ul/li semantic#30382
Merged
XhmikosR merged 2 commits intotwbs:masterfrom Mar 28, 2020
Merged
v5 tabs - accessibility issue when using ul/li semantic#30382XhmikosR merged 2 commits intotwbs:masterfrom
XhmikosR merged 2 commits intotwbs:masterfrom
Conversation
…ement has role tablist and remove dropdown from visual tests as they've been removed from doc
Contributor
|
LGTM, that's the pattern i'm used to see in van11y's tabpanel for example, and what's recommended by Heydon Pickering in Inclusive Design Patterns' "Tabbed interface". Other ways around are to not use a list at all (eg. @patrickhlauke any opinion on this? |
patrickhlauke
approved these changes
Mar 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v5 fix #30338 add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc
Related to #30381 fix for V4