Add Global Link Decoration Variable#3041
Closed
ctalkington wants to merge 2 commits intotwbs:2.0.3-wipfrom
ctalkington:link-decoration
Closed
Add Global Link Decoration Variable#3041ctalkington wants to merge 2 commits intotwbs:2.0.3-wipfrom ctalkington:link-decoration
ctalkington wants to merge 2 commits intotwbs:2.0.3-wipfrom
ctalkington:link-decoration
Conversation
Member
|
Thanks, but I don't think we need this as a global variable. There will continue to be properties in the future that we consider adding to the BS core and not all of them need to be customizable right out of the gate. The whole variable for every property thing is starting to look like too much overhead honestly, so I'd like to keep us from getting there at all costs. |
This was referenced Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost every property in
scaffoldingallowed for variable override except link text-decoration. This should give a little more control of those properties.