Conversation
XhmikosR
force-pushed
the
master-xmr-rollup-babel
branch
5 times, most recently
from
6a0ca51 to
f90273d
Compare
XhmikosR
force-pushed
the
master-xmr-rollup-babel
branch
2 times, most recently
from
d5bca7f to
154455b
Compare
Member
Author
|
Not sure who can review this, it does seem to work
This one I'm not sure about, but the dist builds are the same. |
XhmikosR
force-pushed
the
master-xmr-rollup-babel
branch
from
d35e08b to
6cfb79d
Compare
Member
Author
|
@mdo I need to proceed someway here... |
mdo
approved these changes
May 26, 2020
XhmikosR
added a commit
that referenced
this pull request
May 26, 2020
XhmikosR
added a commit
that referenced
this pull request
May 29, 2020
XhmikosR
added a commit
that referenced
this pull request
May 30, 2020
XhmikosR
added a commit
that referenced
this pull request
Jun 4, 2020
XhmikosR
added a commit
that referenced
this pull request
Jun 4, 2020
XhmikosR
added a commit
that referenced
this pull request
Jun 4, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30683
Changelog: https://github.com/rollup/plugins/blob/master/packages/babel/CHANGELOG.md#500
So, apart from changing the import, I also had to adapt to the
babelHelpershelper option.Also, I removed the
pluginsoption injs/tests/karma.conf.jssince we already have this in our.babelrc.jsin root, but we need to confirm if it's being discovered automatically.TODO:
.babelrc.jsis discovered and used by karma