Skip to content

v4: Mention GPU acceleration fix in docs callout#30811

Merged
XhmikosR merged 3 commits intov4-devfrom
v4-popovers-gpu
Sep 24, 2020
Merged

v4: Mention GPU acceleration fix in docs callout#30811
XhmikosR merged 3 commits intov4-devfrom
v4-popovers-gpu

Conversation

@mdo
Copy link
Copy Markdown
Member

@mdo mdo commented May 14, 2020 •
edited by XhmikosR
Loading

@ffoodd
Copy link
Copy Markdown
Contributor

ffoodd commented May 14, 2020

Why not include the workaround right here?

@mdo
Copy link
Copy Markdown
Member Author

mdo commented May 14, 2020

Why not include the workaround right here?

Personally I hadn't tested it and wasn't sure if we'd want to include some JS snippet here. I'm down to do that though if folks would prefer it.

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented May 14, 2020

The snippet in #22610 (comment) assumes a bundler AFAICT. We need a snippet to cover all cases.

@mdo
Copy link
Copy Markdown
Member Author

mdo commented Jul 20, 2020 •
edited
Loading

If there's some suggested code or specific change to make here we can get it in, otherwise we have to punt this to another v4.x release. Thoughts @XhmikosR and @Johann-S?

@Johann-S
Copy link
Copy Markdown
Member

Johann-S commented Jul 21, 2020

This snippet cover all cases @XhmikosR because if you import Popper.js with a <script> tag you'll be able to use Popper global variable.

so we can change it, to just that line:

Popper.Defaults.modifiers.computeStyle.gpuAcceleration = !(window.devicePixelRatio < 1.5 && /Win/.test(navigator.platform));

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Jul 24, 2020

Cool, let's move the snippet to the docs and not link to an issue.

vanillajonathan
vanillajonathan reviewed Sep 22, 2020
View reviewed changes
Comment thread site/docs/4.5/components/popovers.md Outdated
{% capture callout %}
##### GPU acceleration

Popovers sometimes appear blurry in Windows 10 devices due to GPU acceleration and a modified system DPI. The workaround for this in v4 is to disable GPU acceleration as needed on your popovers. [See this issue for details and a suggested fix](https://github.com/twbs/bootstrap/issues/22610).
Copy link
Copy Markdown
Contributor

@vanillajonathan vanillajonathan Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in Windows 10" or "on Windows 10 devices", but not "in Windows 10 devices".

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Sep 24, 2020

@Johann-S can you push your proposed snippet to this branch please?

@Johann-S
Copy link
Copy Markdown
Member

Johann-S commented Sep 24, 2020

done @XhmikosR 👍

@XhmikosR XhmikosR merged commit e45fbe7 into v4-dev Sep 24, 2020
@XhmikosR XhmikosR deleted the v4-popovers-gpu branch September 24, 2020 12:06
@XhmikosR XhmikosR mentioned this pull request Sep 24, 2020
Closed
@davidglezz davidglezz mentioned this pull request Oct 15, 2020
Closed
@nelsonni nelsonni mentioned this pull request Jan 5, 2021
Merged
@KostblLb
Copy link
Copy Markdown

KostblLb commented Feb 19, 2021

Still reproduced on 4.6,
i also use @ng-bootstrap/ng-bootstrap@7.0.0, if it matters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

+1 more reviewer

@vanillajonathan vanillajonathan vanillajonathan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs v4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mdo @ffoodd @XhmikosR @Johann-S @KostblLb @vanillajonathan