Skip to content

Disabled checked states wrong background#30922

Merged
XhmikosR merged 2 commits intov4-devfrom
v4-dev-fod-disabled-checked-custom-inputs
Jun 15, 2020
Merged

Disabled checked states wrong background#30922
XhmikosR merged 2 commits intov4-devfrom
v4-dev-fod-disabled-checked-custom-inputs

Conversation

@ffoodd
Copy link
Copy Markdown
Contributor

@ffoodd ffoodd commented May 29, 2020

Fixes #29809 for v4.

V5 doesn't need this since :disabled simply decreases opacity for disabled fields, whatever their background is.

@ffoodd ffoodd requested a review from a team as a code owner May 29, 2020 09:46
@ffoodd ffoodd force-pushed the v4-dev-fod-disabled-checked-custom-inputs branch from 6921d97 to bb37992 Compare May 29, 2020 09:47
@XhmikosR XhmikosR merged commit 7b5e48d into v4-dev Jun 15, 2020
@XhmikosR XhmikosR deleted the v4-dev-fod-disabled-checked-custom-inputs branch June 15, 2020 05:41
@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Jun 21, 2020

@ffoodd it seems this results in duplicate background-color properties:

 .custom-checkbox .custom-control-input:disabled:checked ~ .custom-control-label::before {
   background-color: rgba(0, 123, 255, 0.5);
+  background-color: rgba(0, 123, 255, 0.5);
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

disabled custom checkbox with gradients is not grayed out in checked state

3 participants