Prevent .row from shrinking in flex container#30940
Merged
MartijnCuppens merged 2 commits intomasterfrom Jun 8, 2020
Merged
Conversation
mdo
approved these changes
Jun 4, 2020
Member
|
Why do we set the |
Contributor
Author
|
I always use the Do we stick with |
Member
Yeah we should. |
Member
|
Scratch that, a |
MartijnCuppens
approved these changes
Jun 8, 2020
MartijnCuppens
changed the title
.row from shrinking in flex container
XhmikosR
pushed a commit
that referenced
this pull request
Jun 9, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Jun 10, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Jun 12, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Jun 13, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Jun 17, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Jun 23, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Jun 24, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30840
Working around this issue, this seems the simplest and cleanest way to prevent row from shrinking.
Didn't notice any drawback yet, since it'll only be applied if .row's parent is a flex container.
FYI it'll still break if .row's parent is
display: flexbut doesn't allow wrapping. Don't know if it should be adressed at all, though.@mdo @MartijnCuppens you know rows and history better than I do, so feel free to drop this if it looks wrong.