Conversation
Member
|
Wondering if we could do |
Contributor
Author
|
All toasts would be 350px wide (or 100%), whereas for now it's fluid under 350px. Our toasts examples currently don't reach 350px, so they'd become wider. I think it'd be a good idea to normalize toast size, however it could come back as a bug.
Should at least be done on v5 though. What do you think for v4? Want to give |
Member
|
Oh word, yeah that makes sense then lol. Let's skip the |
mdo
reviewed
Jun 3, 2020
XhmikosR
reviewed
Jun 4, 2020
334bef4 to
0c63023
Compare
mdo
approved these changes
Jun 10, 2020
Member
|
@axzx please make a new issue. Commenting in old issues is moot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #28341
I don't really know what happens here, I tried several known bugs and fixes without any luck. So here's my solution:
flex-basisseems better than fixingwidthsince it has no impact on non-flexible toasts