Merged
Conversation
ffoodd
changed the title
Contributor
Author
|
Well, I don't get it but Autoprefixer doesn't seem to apply here. Don't know why it did in #30836. |
ffoodd
force-pushed
the
v4-dev-fod-IE11-floating-labels
branch
from
2aa810e to
8ec508d
Compare
ffoodd
force-pushed
the
v4-dev-fod-IE11-floating-labels
branch
from
8ec508d to
c07fdbc
Compare
Member
|
@ffoodd it's normal, it's because in my v4 backport and updates PR I updated autoprefixer. Let's get that merged first :) |
mdo
approved these changes
Jun 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IE11
While checking #30836, I came across floating labels in IE11 that could just work fine since it supports a vendor prefixed version of
::placeholder-shownand Autoprefixer just does it job…Preview: https://deploy-preview-30965--twbs-bootstrap.netlify.app/docs/4.5/examples/floating-labels/
Edge
Moreover the Edge workaround uses
display: noneto hide labels, which is a pitty from an accessibility perspective.However Edge also concerns v5, so I'll target
masterfor this and it should be backported late (Xref: #30966).