avoid preventing input event onclick

[Lausselloic]

instead of stopping event if onclick is triggered on input, call toggle method only if its not on checkbox inside a label

fix #30849 following regression introduced by #30388

[XhmikosR]

@Lausselloic thanks! Would it be possible to add a test case? Because this wasn't caught there.

[XhmikosR]

Do we need a PR against master too?

[Lausselloic]

I don't make the initial PR to the master branch, so I need to PR the initial fix and that one to master

[XhmikosR]

OK, if it applies to master too yeah. But we need a test case for both either way to make sure this doesn't happen again :)

[Lausselloic]

unit test added, need to port patrick fix (24abed1) and my PR's to master

[XhmikosR]

Are you sure the unit test covers the opposite too?

Thanks for the patches, and waiting for the master PR later :)

[Lausselloic]

no it just test if event is propagate to the input wrong unit test title. I could add one to ensure event is also emit on label (I will update my PR)

[patrickhlauke]

assume this was tested thoroughly to ensure keyboard triggering still works properly? I seem to remember the prevent stuff was necessary to make it work for kbd while also stopping Firefox from double-triggering on mouse interaction.

[XhmikosR]

I tested as good as I could, but please confirm too.

[patrickhlauke]

checked https://deploy-preview-30992--twbs-bootstrap.netlify.app/docs/4.5/components/buttons/#checkbox-and-radio-buttons in chrome, firefox and even IE11 ... all seems to be working fine. good stuff!