Skip to content

Change "whitelist" to "allowlist"#31066

Merged
XhmikosR merged 14 commits intomainfrom
v5-allowList
Jun 19, 2020
Merged

Change "whitelist" to "allowlist"#31066
XhmikosR merged 14 commits intomainfrom
v5-allowList

Conversation

@patrickhlauke
Copy link
Copy Markdown
Member

@patrickhlauke patrickhlauke commented Jun 17, 2020

Closes #31064

note that this leaves intact the use of blacklist for stylelint

@patrickhlauke patrickhlauke requested a review from mdo June 17, 2020 08:46
@patrickhlauke patrickhlauke requested a review from a team as a code owner June 17, 2020 08:46
XhmikosR
XhmikosR requested changes Jun 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge I want to have a closer look.

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Jun 17, 2020

From a quick look, the change needs to be listed in the migration page in detail.

I will check later the branch.

@patrickhlauke
Copy link
Copy Markdown
Member Author

patrickhlauke commented Jun 17, 2020

ah, was thinking about migration guide, but then thought that it's not really a user/developer facing object (unless somebody was hooking directly into the function for some reason).

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Jun 17, 2020

ah, was thinking about migration guide, but then thought that it's not really a user/developer facing object (unless somebody was hooking directly into the function for some reason).

Yeah, it's a breaking change so it needs to be documented. :)

@patrickhlauke patrickhlauke mentioned this pull request Jun 17, 2020
Closed
@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Jun 17, 2020

Pending the Migration addition, otherwise the changes look good.

@patrickhlauke
Copy link
Copy Markdown
Member Author

patrickhlauke commented Jun 17, 2020

added migration guide entry ... too detailed or ok? @XhmikosR

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Jun 17, 2020 •
edited
Loading

I'd like @Johann-S opinion, not sure if all of the listed methods are public. We should only list public stuff.

AFAICT only allowList is public.

mdo
mdo reviewed Jun 17, 2020
View reviewed changes
Comment thread site/content/docs/5.0/components/popovers.md Outdated
Comment thread site/content/docs/5.0/components/tooltips.md Outdated
patrickhlauke and others added 3 commits June 17, 2020 23:29
mdo
mdo approved these changes Jun 18, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@patrickhlauke
Copy link
Copy Markdown
Member Author

patrickhlauke commented Jun 18, 2020

@Johann-S thoughts on the migration guide question? does it look good or does it need to be expanded?

@Johann-S
Copy link
Copy Markdown
Member

Johann-S commented Jun 19, 2020

LGTM on the migration guide, since it's a public option it's important to be added in our migration guide

@XhmikosR XhmikosR merged commit edbcc40 into main Jun 19, 2020
@XhmikosR XhmikosR deleted the v5-allowList branch June 19, 2020 08:31
@XhmikosR XhmikosR changed the title Change whitelist to allowlist Change "whitelist" to "allowlist" Jul 7, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@patrickhlauke @XhmikosR
@mdo @olsza
Change whitelist to allowlist (twbs#31066)
06264c5 
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
@markcocker markcocker mentioned this pull request Mar 31, 2021
Closed
@lachlansimpson
Copy link
Copy Markdown

lachlansimpson commented Jan 3, 2023

Note that stylelint removed *-blacklist https://github.com/stylelint/stylelint/releases/tag/13.7.0 - can this be revisited?

@lachlansimpson lachlansimpson mentioned this pull request Jan 3, 2023
Closed
4 tasks
patrickhlauke added a commit that referenced this pull request Jan 3, 2023
@patrickhlauke
Change stylelint property-blacklist to property-disallowed-list
033097b 
see #31066 (comment) / https://github.com/stylelint/stylelint/releases/tag/13.7.0

xref #31066
@patrickhlauke patrickhlauke mentioned this pull request Jan 3, 2023
Merged
10 tasks
mdo pushed a commit that referenced this pull request Jan 4, 2023
@patrickhlauke @mdo
Change stylelint property-blacklist to property-disallowed-list
fa87dae 
see #31066 (comment) / https://github.com/stylelint/stylelint/releases/tag/13.7.0

xref #31066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdo mdo mdo approved these changes

@XhmikosR XhmikosR XhmikosR approved these changes

@Johann-S Johann-S Johann-S approved these changes

+1 more reviewer

@core23 core23 core23 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

js no-backport-to-v4 v5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC] Remove blacklist and other oppressive terminology

6 participants

@patrickhlauke @XhmikosR @Johann-S @lachlansimpson @mdo @core23