Skip to content

Docs: (subjectively) nicer looking accordion example #31137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickhlauke merged 9 commits into from
Sep 10, 2020
Merged

Docs: (subjectively) nicer looking accordion example #31137

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
507e6b3
Docs: (subjectively) nicer looking accordion example
patrickhlauke Jun 21, 2020
98b2762
Merge branch 'main' into v5-docs-better-accordion
patrickhlauke Jul 3, 2020
4ab95d7
Merge branch 'main' into v5-docs-better-accordion
patrickhlauke Jul 4, 2020
cbdd523
Merge branch 'main' into v5-docs-better-accordion
patrickhlauke Aug 1, 2020
25a9135
Add extra classes for nicer overall look
patrickhlauke Aug 1, 2020
05a92c7
Merge branch 'v5-docs-better-accordion' of https://github.com/twbs/bo…
patrickhlauke Aug 1, 2020
58a9d5f
Tweak accessibility note for accordions and optional keyboard interac…
patrickhlauke Aug 1, 2020
ff8d253
Merge branch 'main' into v5-docs-better-accordion
patrickhlauke Aug 26, 2020
bb80826
Merge branch 'main' into v5-docs-better-accordion
patrickhlauke Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions site/content/docs/5.0/components/collapse.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ Using the [card]({{< docsref "/components/card" >}}) component, you can extend t
{{< example >}}
<div class="accordion" id="accordionExample">
<div class="card">
<div class="card-header" id="headingOne">
<div class="card-header p-0" id="headingOne">
<h2 class="mb-0">
<button class="btn btn-link btn-block text-left" type="button" data-toggle="collapse" data-target="#collapseOne" aria-expanded="true" aria-controls="collapseOne">
<button class="btn btn-light btn-block text-left p-3 rounded-0" type="button" data-toggle="collapse" data-target="#collapseOne" aria-expanded="true" aria-controls="collapseOne">
Collapsible Group Item #1
</button>
</h2>
Expand All @@ -91,9 +91,9 @@ Using the [card]({{< docsref "/components/card" >}}) component, you can extend t
</div>
</div>
<div class="card">
<div class="card-header" id="headingTwo">
<div class="card-header p-0" id="headingTwo">
<h2 class="mb-0">
<button class="btn btn-link btn-block text-left collapsed" type="button" data-toggle="collapse" data-target="#collapseTwo" aria-expanded="false" aria-controls="collapseTwo">
<button class="btn btn-light btn-block text-left collapsed p-3 rounded-0" type="button" data-toggle="collapse" data-target="#collapseTwo" aria-expanded="false" aria-controls="collapseTwo">
Collapsible Group Item #2
</button>
</h2>
Expand All @@ -105,9 +105,9 @@ Using the [card]({{< docsref "/components/card" >}}) component, you can extend t
</div>
</div>
<div class="card">
<div class="card-header" id="headingThree">
<div class="card-header p-0" id="headingThree">
<h2 class="mb-0">
<button class="btn btn-link btn-block text-left collapsed" type="button" data-toggle="collapse" data-target="#collapseThree" aria-expanded="false" aria-controls="collapseThree">
<button class="btn btn-light btn-block text-left collapsed p-3 rounded-0" type="button" data-toggle="collapse" data-target="#collapseThree" aria-expanded="false" aria-controls="collapseThree">
Collapsible Group Item #3
</button>
</h2>
Expand All @@ -127,7 +127,7 @@ Be sure to add `aria-expanded` to the control element. This attribute explicitly

If your control element is targeting a single collapsible element – i.e. the `data-target` attribute is pointing to an `id` selector – you should add the `aria-controls` attribute to the control element, containing the `id` of the collapsible element. Modern screen readers and similar assistive technologies make use of this attribute to provide users with additional shortcuts to navigate directly to the collapsible element itself.

Note that Bootstrap's current implementation does not cover the various keyboard interactions described in the [WAI-ARIA Authoring Practices 1.1 accordion pattern](https://www.w3.org/TR/wai-aria-practices-1.1/#accordion) - you will need to include these yourself with custom JavaScript.
Note that Bootstrap's current implementation does not cover the various *optional* keyboard interactions described in the [WAI-ARIA Authoring Practices 1.1 accordion pattern](https://www.w3.org/TR/wai-aria-practices-1.1/#accordion) - you will need to include these yourself with custom JavaScript.

## Usage

Expand Down