Restore and deprecate make-container-max-widths mixin#31438
Conversation
|
This is currently a blocker on a rather urgent project. Any chance it will be merged soon? If not, I'll just require 4.5.0 exactly for now. |
|
Hoping to do a v4.5.2 tomorrow to patch this. Doing some digging and testing other things out. Lock in at v4.5.0 exactly for now to keep yourself unblocked if you can. |
|
@mdo Do we need the mixin in main, though? We could only target v4-dev where this was a breaking change, right? |
|
Yup, we can retarget this one. |
|
Let's add the deprecation warning too so that we are covered since the mixin is removed from v5. @twbs/css-review in case you can help us here to move faster. |
1de415d to
99de9c8
Compare
|
Is there any documentation or an upgrade note what one should use instead of |
|
would be good if there are list of depreciated and its replacement. Really annoying docs :( . |
We removed this to de-dupe our grid containers in our compiled CSS (see #30969) and I wasn't thinking when reviewing that it'd be a breaking change. We're sticking with not using the mixin, but adding the mixin back for others to use.
We may need to add a deprecation notice to it as well.
Fixes #31436, fixes #31440